Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Prometheus: some per-exchange/per-queue metrics aggregated per-channel #11726

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

gomoripeti
Copy link
Contributor

(this is @LoisSotoLopez 's work, submitting while he is away)

Mostly identical to #11559 with tests fixed, and some minor renaming and reordering.

Proposed Changes

Add copies of some per-object metrics that are labeled per-channel aggregated to reduce cardinality. These metrics are valuable and easier to process if exposed on per-exchange and per-queue basis.

Implements #11217

TODO: document new metric groups

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

Further Comments

Add copies of some per-object metrics that are labeled per-channel
aggregated to reduce cardinality. These metrics are valuable and
easier to process if exposed on per-exchange and per-queue basis.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants