Definition import: allow for arbitrary (and pluggable) sources #3311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This makes the definition import mechanism generic and pluggable
(think peer discovery mechanisms) and not tied to a local file
or directory of files. This can be particularly convenient in environments
where running RabbitMQ in a container is the preferred or the only option,
such as GitLab or GitHub service containers used in integration tests.
See docker-library/rabbitmq#508 for some background on this.
The classic local filesystem source is still supported
using the same traditional configuration key,
load_definitions
.Configuration schema follows peer discovery in spirit:
which can be a module provided by a plugin
keys a specific mechanism needs
For example, the classic local filesystem source can now be
configured like this:
HTTPS may require additional configuration keys related to TLS/x.509
peer verification. Such extra keys will be added as the need for them
becomes evident.
Types of Changes
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.
CONTRIBUTING.md
documentFurther Comments
References #3249.