Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix handling shovels with old supervisor id format #9965

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

gomoripeti
Copy link
Contributor

@gomoripeti gomoripeti commented Nov 21, 2023

Proposed Changes

  • Don't create shovel if already exists with old sup id

    Before 3.13.0 and 3.12.8 supervisor id format was different. Don't
    start a shovel with the new id format if one exists with the old id
    format.

  • Fix deleting and cleanup of shovels with old ids

Fixes #9964

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

Before 3.13.0 and 3.12.8 supervisor id format was different. Don't
start a shovel with the new id format if one exists with the old id
format.
@michaelklishin michaelklishin added this to the 3.12.10 milestone Nov 21, 2023
@michaelklishin michaelklishin merged commit e679155 into rabbitmq:v3.12.x Nov 21, 2023
@michaelklishin michaelklishin removed this from the 3.12.10 milestone Nov 21, 2023
@gomoripeti
Copy link
Contributor Author

gomoripeti commented Nov 21, 2023

Please don't release 3.12.10 just yet. I found another issue while testing. I am sorry about the not good quality contribution.

Also is there a way to add mixed version cluster tests to shovels? What is the "old" version that mixed version tests use?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants