Fix handling methods with annotated parameters and test suite #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem with current version of the test suite is that it actualy covers only first test executed. The reason is all test cases use the same set of configuration parameters (test.*). After the first test gets executed, all configuration parameters are already bound. It leads to a situation when all following tests become nearly useless. This goal of this commit is to provide separate data set to each test case (pojo via constructor, pojo via fields, pojo via methods and provided pojo).
|
Thanks for this - nice find! |
racc
added a commit
that referenced
this pull request
Nov 9, 2015
Fix handling methods with annotated parameters and test suite
|
Thanks for merging and for developing this very useful module. Please, publish fixed version to maven central when you have time. |
racc
pushed a commit
that referenced
this pull request
Nov 9, 2015
|
Thanks for the feedback! I've published version 0.0.2 which includes your fix. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with current version of the test suite is that it actually covers only first test executed. The reason is all test cases use the same set of configuration parameters (test.*). After the first test gets executed, all configuration parameters are already bound. It leads to a situation when all following tests become nearly useless. In particular, provided pojo test succeeds despite of the invalid resolution of methods with annotate parameters logic (see below).
The goal of this fix is to provide separate data set to each test case (pojo via constructor, pojo via fields, pojo via methods and provided pojo).
Also this pull request provides a fix to the invalid methods with annotated parameters resolution. Currently "org.reflections.Reflections.getMethodsAnnotatedWith" method is used to retrieve methods with annotated parameters. However, this method searches for methods annotated with some annotation, not the methods with annotated parameters. I believe "org.reflections.Reflections.getMethodsWithAnyParamAnnotated" method would be the correct one in this case.