Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for :query_params to set query parameters for non-GET requests #287

Merged
merged 2 commits into from
May 2, 2022

Conversation

jeremyevans
Copy link
Contributor

This allows you to set both body parameters (:params) and query
parameters (:query_params) for non-GET requests.

For consistency, GET requests also support :query_params. If both
:params and :query_params are provided, :params will append to the
existing query before :query_params.

Implements #150.

…uests

This allows you to set both body parameters (:params) and query
parameters (:query_params) for non-GET requests.

For consistency, GET requests also support :query_params.  If both
:params and :query_params are provided, :params will append to the
existing query before :query_params.

Implements rack#150.
Rubocop will probably be ripped out completely in the future, but
for right now, just disable the rules that are complaining.
Copy link
Member

@ioquatix ioquatix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jeremyevans jeremyevans merged commit 1dd06c1 into rack:main May 2, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants