Implement nova get_version #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benjamin91300
force-pushed
the
nova_version
branch
from
8e6927d to
46e6c2e
Compare
| @@ -184,6 +193,23 @@ def setUp(self): | |||
| create_server(self.helper, name=self.server_name)) | |||
| self.server_id = self.create_server_response_body['server']['id'] | |||
|
|
|||
| def test_get_version_nova(self): | |||
| """ | |||
| Check response when listing available version of nova. | |||
There was a problem hiding this comment.
Could you add a citation for this that points at Nova's docs?
There was a problem hiding this comment.
@Benjamin91300 please reference http://developer.openstack.org/api-ref-compute-v2.1.html
|
Please just address the minor test doc issue and land. |
|
@glyph, @BenjamenMeyer: I hope it is what you expected. |
|
@Benjamin91300 I would add it to the handler of the response itself, not simply the test (https://github.com/rackerlabs/mimic/pull/619/files#diff-623976324cdaaa34626dd686efc298b9R34). Once that and the current merge conflict are resolved then I'll merge it as it otherwise LGTM. |
Recent novaclient versions and openstackclient require resource /compute/v2. This commit provides it.
Benjamin91300
force-pushed
the
nova_version
branch
from
1fe0876 to
4b78062
Compare
Recent novaclient versions and openstackclient require resource /compute/v2. This commit provides it.
|
👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent novaclient versions and openstackclient require resource
/compute/v2. This commit provides it.