Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Prefix 'e when setting multiple symbol servers #370

Closed
wants to merge 1 commit into from

Conversation

davispuh
Copy link
Contributor

Checklist

  • Closing issues: #issue
  • Mark this if you consider it ready to merge
  • I've added tests (optional)
  • I wrote some documentation

Description

Prefix 'e when setting multiple symbol servers

@trufae
Copy link
Contributor

trufae commented Feb 22, 2024

Personally i think we should use space or comma as separator token instead. The single quote char is a general way to avoid evaluating special characters but you can also use backslash or double quote “ the whole thing. But probably i would prefer to change the code in r2 rather than documenting something that is probably not intuitive

@davispuh
Copy link
Contributor Author

Yeah that would be better. As it is currently " quotes (nor \;) doesn't work either because it interprets it as part of URL...

I think space as separator would make most sense (for actual space in URL you can just use %20) and supporting quotes could be alternate way for '

@trufae
Copy link
Contributor

trufae commented Feb 23, 2024

here we go! radareorg/radare2#22636

thanks !

@trufae trufae closed this Feb 23, 2024
@trufae
Copy link
Contributor

trufae commented Feb 23, 2024

feel free to check the documentation in case its still referencing semicolon somewhere. i think the semicolon syntax comes from the awful windows env separator thing.

@davispuh
Copy link
Contributor Author

Nice! I updated it in #371

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants