Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Custom defined types are not loaded from project files #5898

Closed
bluec0re opened this issue Oct 1, 2016 · 3 comments
Closed

Custom defined types are not loaded from project files #5898

bluec0re opened this issue Oct 1, 2016 · 3 comments
Labels
projects Loading, saving and handling radare2 project files types Parsing, propagating and inferring simple and complex types
Milestone

Comments

@bluec0re
Copy link
Contributor

bluec0re commented Oct 1, 2016

Custom defined types are not loaded from the project file. They are included in the file and can be created by c&p them manually, so it's not an syntax issue.

Bsp:

[0x00000000]> tk char **=type
[0x00000000]> tk type.char **=**z
[0x00000000]> tk type.char **.size=64
[0x00000000]> Ps foo
foo
[0x00000000]> Pc foo ~char **
tk func.getopt.arg.1 = const char **,argv
tk func.__libc_init.arg.1 = char **,argv
tk func.__libc_init.arg.2 = char **,envp
tk func.__libc_start_main.arg.2 = char **,ubp_av
tk char ** = type
tk type.char ** = **z
tk type.char **.size = 64
[0x00000000]> tk ~char **
func.getopt.arg.1=const char **,argv
func.__libc_init.arg.1=char **,argv
func.__libc_init.arg.2=char **,envp
func.__libc_start_main.arg.2=char **,ubp_av
char **=type
type.char **=**z
type.char **.size=64
[0x00000000]> t- char**
[0x00000000]> tk ~char **
func.getopt.arg.1=const char **,argv
func.__libc_init.arg.1=char **,argv
func.__libc_init.arg.2=char **,envp
func.__libc_start_main.arg.2=char **,ubp_av
type.char **.size=64
[0x00000000]> Po foo
[0x00000000]> tk ~char **
func.getopt.arg.1=const char **,argv
func.__libc_init.arg.1=char **,argv
func.__libc_init.arg.2=char **,envp
func.__libc_start_main.arg.2=char **,ubp_av

Radare version:

radare2 0.10.6 12565 @ linux-x86-64 git.0.10.6-28-gc787707
commit: c7877075a125119bb381d78e63cbfd73b0240cae build: 2016-10-02
@radare
Copy link
Collaborator

radare commented Oct 2, 2016

Cc @oddcoder

On 02 Oct 2016, at 01:05, BlueC0re notifications@github.com wrote:

Custom defined types are not loaded from the project file. They are included in the file and can be created by c&p them manually, so it's not an syntax issue.

Bsp:

[0x00000000]> tk char **=type
[0x00000000]> tk type.char **=**z
[0x00000000]> tk type.char **.size=64
[0x00000000]> Ps foo
foo
[0x00000000]> Pc foo ~char **
tk func.getopt.arg.1 = const char *,argv
tk func.__libc_init.arg.1 = char *
,argv
tk func.__libc_init.arg.2 = char *,envp
tk func.__libc_start_main.arg.2 = char *
,ubp_av
tk char ** = type
tk type.char ** = *z
tk type.char *
.size = 64
[0x00000000]> tk ~char **
func.getopt.arg.1=const char *,argv
func.__libc_init.arg.1=char *
,argv
func.__libc_init.arg.2=char *,envp
func.__libc_start_main.arg.2=char *
,ubp_av
char *=type
type.char *
=**z
type.char .size=64
[0x00000000]> t- char

[0x00000000]> tk ~char **
func.getopt.arg.1=const char *,argv
func.__libc_init.arg.1=char *
,argv
func.__libc_init.arg.2=char *,envp
func.__libc_start_main.arg.2=char *
,ubp_av
type.char *.size=64
[0x00000000]> Po foo
[0x00000000]> tk ~char *

func.getopt.arg.1=const char *,argv
func.__libc_init.arg.1=char *
,argv
func.__libc_init.arg.2=char *,envp
func.__libc_start_main.arg.2=char *
,ubp_avfunc.getopt.arg.1=const char *,argv
func.__libc_init.arg.1=char *
,argv
func.__libc_init.arg.2=char *,envp
func.__libc_start_main.arg.2=char *
,ubp_av

Radare version:

radare2 0.10.6 12565 @ linux-x86-64 git.0.10.6-28-gc787707
commit: c787707 build: 2016-10-02

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@Maijin Maijin added the types Parsing, propagating and inferring simple and complex types label Oct 2, 2016
@radare radare added this to the 1.0.0 milestone Oct 4, 2016
@radare
Copy link
Collaborator

radare commented Oct 17, 2016

i have refactored "a bit" the core/project.c it clearly needs much more love, so please test the projects as much as possible. this is an important feature we must care about.

cc @Maijin @oddcoder we must have more tests and verify that everything stays the same before and after saving hte projects

@radare radare added the projects Loading, saving and handling radare2 project files label Oct 30, 2016
@radare radare modified the milestones: 1.1.0, 1.0.0 Nov 8, 2016
@radare radare modified the milestones: 1.2.0, 1.1.0 Dec 13, 2016
@radare
Copy link
Collaborator

radare commented Jan 29, 2017

@oddcoder can you take a look at this?

oddcoder added a commit to oddcoder/radare2 that referenced this issue Jan 29, 2017
Not reloading sdb_types if editing env_vars results no change
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
projects Loading, saving and handling radare2 project files types Parsing, propagating and inferring simple and complex types
Projects
None yet
Development

No branches or pull requests

4 participants