Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix a LGTM alert #16616

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Fix a LGTM alert #16616

merged 1 commit into from
Apr 17, 2020

Conversation

eagleoflqj
Copy link
Contributor

@eagleoflqj eagleoflqj commented Apr 17, 2020 •
edited
Loading

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the documentation and the radare2 book with the relevant information (if needed)

Detailed description

newsize already >=1

Test plan

...

Closing issues

...

@lgtm-com
Copy link

lgtm-com bot commented Apr 17, 2020

This pull request fixes 1 alert when merging c2d1035 into dae5bb4 - view on LGTM.com

fixed alerts:

  • 1 for Comparison result is always the same

@XVilka XVilka merged commit f549eb2 into radareorg:master Apr 17, 2020
@eagleoflqj eagleoflqj deleted the liumeo-patch-2 branch April 17, 2020 02:21
Emi1305 pushed a commit to Emi1305/radare2 that referenced this pull request Jul 12, 2020
@eagleoflqj @Emi1305
Fix LGTM alert - useless comparison (radareorg#16616)
efb09f3
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@radare radare Awaiting requested review from radare

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eagleoflqj @XVilka