Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix crash on quit for hacklu gameboy rom #1678

Closed
wants to merge 1 commit into from

Conversation

crowell
Copy link
Collaborator

@crowell crowell commented Nov 14, 2014

minishwoods hacklu/gunpoint » r2 ./gunslinger.gb                                                                                                                                                                              139 ↵
 -- Show offsets in graphs with 'e graph.offset = true'
[0x00000100]> q
[1]    6263 segmentation fault (core dumped)  r2 ./gunslinger.gb
gdb-peda$ bt
#0  0x0000000000000000 in ?? ()
#1  0x00007f20f32b9f4d in r_asm_free (a=0x1a33f20) at asm.c:186
#2  0x00007f20f5836a56 in r_core_fini (c=0x607560 <r>) at core.c:835
#3  0x000000000040519e in main (argc=0x2, argv=0x7fff212da7a8, envp=0x7fff212da7c0) at radare2.c:756
#4  0x00007f20f1cb6ec5 in __libc_start_main (main=0x402fdc <main>, argc=0x2, argv=0x7fff212da7a8, init=<optimized
#5  0x0000000000402939 in _start ()

This fixes the crash

@radare
Copy link
Collaborator

radare commented Nov 14, 2014

Oops too late

On 14 Nov 2014, at 01:30, Jeffrey Crowell notifications@github.com wrote:

minishwoods hacklu/gunpoint » r2 ./gunslinger.gb 139 ↵
-- Show offsets in graphs with 'e graph.offset = true'
[0x00000100]> q
[1] 6263 segmentation fault (core dumped) r2 ./gunslinger.gb
gdb-peda$ bt
#0 0x0000000000000000 in ?? ()
#1 0x00007f20f32b9f4d in r_asm_free (a=0x1a33f20) at asm.c:186
#2 0x00007f20f5836a56 in r_core_fini (c=0x607560 ) at core.c:835
#3 0x000000000040519e in main (argc=0x2, argv=0x7fff212da7a8, envp=0x7fff212da7c0) at radare2.c:756
#4 0x00007f20f1cb6ec5 in __libc_start_main (main=0x402fdc

, argc=0x2, argv=0x7fff212da7a8, init=<optimized
#5 0x0000000000402939 in _start ()
This fixes the crash

You can merge this Pull Request by running

git pull https://github.com/crowell/radare2 master
Or view, comment on, or merge it at:

#1678

Commit Summary

fix crash on quit for hacklu gameboy rom
File Changes

M libr/asm/asm.c (2)
Patch Links:

https://github.com/radare/radare2/pull/1678.patch
https://github.com/radare/radare2/pull/1678.diff

Reply to this email directly or view it on GitHub.

@crowell
Copy link
Collaborator Author

crowell commented Nov 14, 2014

@radare I see this is fixed in 4bb8a10

@crowell crowell closed this Nov 14, 2014
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants