Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

mips-32 calling convention typo fixed #6440

Merged
merged 1 commit into from
Jan 6, 2017
Merged

Conversation

guedou
Copy link
Contributor

@guedou guedou commented Jan 6, 2017

Here is a small fix to a typo discovered while reading calling convention definitions.

@Maijin Maijin merged commit d24afa0 into radareorg:master Jan 6, 2017
@Maijin
Copy link
Contributor

Maijin commented Jan 6, 2017

If you could add test for this that would be great !

@guedou
Copy link
Contributor Author

guedou commented Jan 11, 2017

I tried the following, but I could not find a way to provide the (fake) prototype of r2_uni_test. Is it possible to do it dynamically ?

rasm2 -a mips 'ADDI A0, A0, 1; ADDI A1, A0, 1; ADDI A2, A1, 1; ADDI A3, A2, 1; JAL 0x28' -B > test.bin
r2 -a mips test.bin -qc 'e asm.emu=true; af+ 0x28 1 r2_unit_test; pd 5'

@radare
Copy link
Collaborator

radare commented Jan 11, 2017 via email

@radare radare mentioned this pull request Jan 31, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants