Constrain Signer::Error
#30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In practice, most errors need to satisfy:
std::error::Error + Send + Sync + 'static
and `Signer::Error` is no exception.
By defining the bound on the trait here, some wild tricks involving
associated type bounds can be removed from `link-crypto`. This lets us
avoid a compiler bug in recent `rustc`s [0] without compromising
errrrgonomics.
[0]: rust-lang/rust#90691
Signed-off-by: Kim Altintop <kim@eagain.st>
|
Looks like your edition2021 woes are not behind you |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In practice, most errors need to satisfy:
and
Signer::Erroris no exception.By defining the bound on the trait here, some wild tricks involving
associated type bounds can be removed from
link-crypto. This lets usavoid a compiler bug in recent
rustcs 0 without compromisingerrrrgonomics.