Bump gulp-eslint to work with used babel-eslint #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`gulp lint` fails with `Parsing error: Cannot find module 'eslint-scope' from '/usr/src/extension/node_modules/eslint/lib/api.js'` This is because `babel-eslint@^10.0.1` (introduced at pull request #209) requires newer `eslint` than the one installed by `gulp-eslint`, which is clearly stated during `npm install` stage: `npm WARN babel-eslint@10.0.3 requires a peer of eslint@>= 4.12.1 but none is installed. You must install peer dependencies yourself.` This pull request updates `gulp-eslint` to the latest v6.0.0, which has `eslint@^6.0.0` as dependency, thus satisfying `babel-eslint` peer dependency requirement.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gulp lintfails withParsing error: Cannot find module 'eslint-scope' from '/usr/src/extension/node_modules/eslint/lib/api.js'This is because
babel-eslint@^10.0.1(introduced at pull request #209) requires newereslintthan the one installed bygulp-eslint, which is clearly stated duringnpm installstage:npm WARN babel-eslint@10.0.3 requires a peer of eslint@>= 4.12.1 but none is installed. You must install peer dependencies yourself.This pull request updates
gulp-eslintto the latest v6.0.0, which haseslint@^6.0.0as dependency, thus satisfyingbabel-eslintpeer dependency requirement.