Feature/dapp improve display and input components #2920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to specify an optional label for the amount display component. Furthermore it can be set to be full width. This makes basically only sense in combination with a label. The display amount usage in the transfer component had to be adopted due to these changes. The unit tests of the amount display were extended, but also refactored to align with the most recent standards.
This allows to specify an optional label for the address display component. Furthermore it can be set to be full width. This makes basically only sense in combination with a label. The display amount usage in the transfer component had to be adopted due to these changes.
Depending on where the address input component is used, the excluded addresses are defined differently. The according error message when a user types one of those addresses should reflect the specific case.
|
No CHANGELOG entry necessary for this. No new feature or bugfix for the user. |
Codecov Report
@@ Coverage Diff @@
## master #2920 +/- ##
==========================================
- Coverage 93.77% 93.07% -0.71%
==========================================
Files 116 199 +83
Lines 6348 8015 +1667
Branches 1140 1339 +199
==========================================
+ Hits 5953 7460 +1507
- Misses 340 458 +118
- Partials 55 97 +42
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
3 tasks
As he address input component can be configured to exclude a list of addresses that are not allowed to be used, this ads the option to restrict the input to a fixed list of allowed addresses. A practical use case is for example the selection of a channel partner to make a deposit to. The unit tests of the amount input component are a nightmare. But that became too big to easily improve them now.
When it fails to parse a balance for a token, instead of failing with an uncaught error (e.g. amount display) it falls back to zero. This lead automatically leads to all actions to fail due to a non-positive amount.
The default for an empty amount input might be set to zero. Depending on the decimals of the targeted token, this should switch between `0` and `0.00`. This was formerly done by other components using the amount input component. This got hereby simplified and keep it within this component.
|
All feedback addressed. I'll will squash the fixup commits now. |
weilbith
force-pushed
the
feature/dapp-improve-display-and-input-components
branch
from
64a8c4c to
db64faf
Compare
|
I'll wait for the CI to confirm and then I'll merge. Afterwards I'll rebase #2921 on top of it. |
weilbith
deleted the
feature/dapp-improve-display-and-input-components
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR got split out of a bigger PR that will come afterwards. It basically includes a couple a smaller improvements which will be used later.