Skip to content

Preserve path when string is camelized #1987

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sineed
Copy link

@sineed sineed commented Nov 22, 2016

Purpose

In my project I have some cases when I need to make a POST request with nested data. The following data may be provided:

{
  "data": {
    "type": "offers",
    "attributes": {
      "bid": { "amount": 1.12, "currency": "USD" }
    }
  }
}

Bid attribute may have validation errors so the response should provide this information:

{
  "errors": [
    { "source": { "pointer": "/data/attributes/bid/amount" }, "detail": "too_low" }
  ]
}

But when I use camel key transformation I receive /data/attributes/bid::Amount instead of /data/attributes/bid/amount

This PR fixes this behavior for camel and camel_lower key transformations

Changes

In camel and camel_lower key transformations

Caveats

I saw work at #1928 and introduction of case_transform. I can make PR to this gem also.

Related GitHub issues

#1928

Additional helpful information

@mention-bot
Copy link

@sineed, thanks for your PR! By analyzing the history of the files in this pull request, we identified @remear, @dubadub and @iancanderson to be potential reviewers.

@bf4
Copy link
Member

bf4 commented May 1, 2017

So the value is being transformed? that doesn't seem right

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants