Skip to content

Redefine isolation level method as MSSSQL resets isolation after transaction #1324

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 4, 2025
Merged

Redefine isolation level method as MSSSQL resets isolation after transaction #1324

merged 3 commits into from
Apr 4, 2025

Conversation

aidanharan
Copy link
Contributor

Redefine isolation level method as MSSSQL resets isolation level after transaction unlike MySQL/PostgreSQL.

https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/14250370905/job/39941435835

 1) Failure:
TransactionIsolationTest#test_0003_default_isolation_level [/usr/local/bundle/bundler/gems/rails-e0452e80137c/activerecord/test/cases/transaction_isolation_test.rb:80]:
Expected: 1
  Actual: 2

@aidanharan aidanharan marked this pull request as ready for review April 4, 2025 15:52
@aidanharan aidanharan merged commit da6238c into main Apr 4, 2025
6 checks passed
@aidanharan aidanharan deleted the coerce_with_default_isolation_level_test branch April 4, 2025 15:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rails-8.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aidanharan