Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update CI matrix #267

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Update CI matrix #267

merged 1 commit into from
Oct 6, 2024

Conversation

byroot
Copy link
Member

@byroot byroot commented Oct 6, 2024

Rails main is no longer compatible with Ruby 3.1.

@byroot byroot force-pushed the fix-ci-matrix branch 4 times, most recently from 5bd61a2 to 8ae9e32 Compare October 6, 2024 15:58
Rails main is no longer compatible with Ruby 3.1.
@byroot
Copy link
Member Author

byroot commented Oct 6, 2024

There's one failure left but I don't know enough about this project to fix it:

 Error:
InstallerTest#test_installer_task:
Errno::ENOENT: No such file or directory @ rb_sysopen - app/assets/config/manifest.js
    test/installer_test.rb:19:in `read'
    test/installer_test.rb:19:in `block (2 levels) in <class:InstallerTest>'
    test/installer_test.rb:69:in `block (2 levels) in with_new_rails_app'
    test/installer_test.rb:57:in `chdir'
    test/installer_test.rb:57:in `block in with_new_rails_app'
    /opt/hostedtoolcache/Ruby/3.2.5/x64/lib/ruby/3.2.0/tmpdir.rb:94:in `mktmpdir'
    test/installer_test.rb:52:in `with_new_rails_app'
    test/installer_test.rb:8:in `block in <class:InstallerTest>'

bin/rails test /home/runner/work/importmap-rails/importmap-rails/test/installer_test.rb:7

But the CI is now way more green than it was so I'll merge.

@byroot byroot merged commit 022433e into rails:main Oct 6, 2024
20 of 22 checks passed
@byroot byroot deleted the fix-ci-matrix branch October 6, 2024 16:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant