Skip to content

Handle data URLs better #134

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed

Conversation

goromlagche
Copy link

@goromlagche goromlagche commented Jun 8, 2022

Trying to address #135

@goromlagche goromlagche force-pushed the handle-data-mediatypes-better branch from 3f0a725 to 97e67bc Compare June 8, 2022 12:31
@goromlagche goromlagche changed the title Handle data mediatypes better Handle data URLs better Jun 8, 2022
@flavorjones
Copy link
Member

Thank you for proposing these changes. I'll take a deeper look shortly.

@flavorjones
Copy link
Member

I think there's a deeper conversation about the functional drift between Loofah and rails-html-sanitizer, and I've started a discussion about it at #136

Until that discussion has been had, I'd like to hold off on making a decision about this specific solution.

@goromlagche
Copy link
Author

That's awesome. I was thinking about something along the line, but just was not sure how to implement the same. 👍

@flavorjones
Copy link
Member

Hi, @goromlagche, thanks so much for your patience on this. I'm preparing a security release of Rails::Html::Sanitizer and I've decided to implement a slightly different solution that involves depending on a refactored Loofah class. I'll follow up with you in #135

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants