Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement Engines support #484

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bopm
Copy link

@bopm bopm commented Jan 29, 2025

This PR implements support for Rails Engines Tailwind styles. It does not require configuration, but sets basic conventions and allows users to redefine engine styles in the host application.

@flavorjones
Copy link
Member

Thanks for thinking about this!

I'd like to land v4 support before I think about what's next, so it may be a day or two before I can review and give good feedback.

@bopm
Copy link
Author

bopm commented Jan 29, 2025

Totally, this needs v4 to work. Ping me when you get to this, I am happy to add missing parts including tests.

@bopm
Copy link
Author

bopm commented Feb 10, 2025

@flavorjones any updates for your expectations here?

@flavorjones
Copy link
Member

@bopm I appreciate your patience. Reviewing this PR is near, but not at, the top of my list and this is going to be a very busy week for me.

@bopm
Copy link
Author

bopm commented Feb 10, 2025

Sure, once again, take your time. I only keeping hand on a pulse to be sure it's not blocked by you possibly waiting on something from me.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants