Skip to content

Update v4 guide, add section about new namespaces #1929

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 4, 2019

Conversation

yvbeek
Copy link
Contributor

@yvbeek yvbeek commented Feb 6, 2019

  • A few small layout changes to keep it in style with the other docs
  • Added a section about the new namespaces
  • Mention of the v4 upgrade guide in the main README

Copy link
Contributor

@connorshea connorshea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yvbeek yvbeek mentioned this pull request Feb 9, 2019
@codebryo
Copy link

Changes look amazing. Thanks for the clarity!

@gauravtiwari
Copy link
Member

Thanks @ZyphraX Could you please rebase with master?

@yvbeek yvbeek force-pushed the feature-upgrade-guide-v4 branch from 735da1a to e42d452 Compare March 3, 2019 23:28
@yvbeek
Copy link
Contributor Author

yvbeek commented Mar 3, 2019

@gauravtiwari Done!

@gauravtiwari gauravtiwari merged commit 6954c71 into rails:master Mar 4, 2019
@manju345
Copy link

/money:Exchange

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants