Fix sass option and nix additional yarn install task #2500
Conversation
| sassOptions: { | ||
| includePaths | ||
| } |
There was a problem hiding this comment.
I believe this means that we should go for sass-loader ^8.0.0, WDYT?
https://github.com/webpack-contrib/sass-loader/blob/master/CHANGELOG.md#-breaking-changes
Previously:
https://github.com/webpack-contrib/sass-loader/tree/v7.3.1#options
Current:
https://github.com/webpack-contrib/sass-loader/tree/v8.0.2#object
There was a problem hiding this comment.
Ahh I see. Yeah, lets do that.
I am thinking to try and upgrade master to webpack 5 beta too and see if everything works as intended but in another pr.
|
Hey! Thanks for the PR! Does this solve #1951 by any chance? As in, does |
|
Hey, I am not sure really, will work on this pr bit later today and update 👍 |
|
closing in favour of #2508 Will open another pr with remaining changes. |
Please see: https://webpack.js.org/loaders/sass-loader/#sassoptions
and since we are supporting Rails > 5.2 we can safely remove webpacker yarn install enhance task.