Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support to Yarn v2/berry for webpacker 5.x #2889

Merged
merged 6 commits into from
Jan 21, 2021
Merged

Support to Yarn v2/berry for webpacker 5.x #2889

merged 6 commits into from
Jan 21, 2021

Conversation

pedrofurtado
Copy link
Member

@pedrofurtado pedrofurtado commented Jan 15, 2021

@gauravtiwari 👋

Closes #2888.

Clone of #2799 to provide support of Yarn v2 in 5.x versions of webpacker.

@pedrofurtado
Copy link
Member Author

@gauravtiwari It worked like a charm! 🎉

PS: There are some errors in CI, but is not related to source code of PR, is related to some ruby version installed during build process 👍

@pedrofurtado
Copy link
Member Author

@gauravtiwari Happy to see your review/suggestions on it 🎉 🥇

@gauravtiwari gauravtiwari merged commit 2f0f955 into rails:5-x-stable Jan 21, 2021
@pedrofurtado pedrofurtado deleted the 5-x-stable branch January 21, 2021 11:50
@merobal
Copy link

merobal commented Mar 11, 2021

Do you have any plan to release this? @pedrofurtado @gauravtiwari

@pedrofurtado
Copy link
Member Author

Hi @merobal ! 👋 Yes, asap we will prepare a 5.x release 🎉

@jerrod
Copy link

jerrod commented Apr 10, 2021

@pedrofurtado any chance this updated release will happen reasonably soon?

@SampsonCrowley
Copy link
Contributor

SampsonCrowley commented Sep 27, 2021

@pedrofurtado was this released? I'm still seeing this on latest 5.x (5.4.3) more than 5 months later

Screenshot from 2021-09-27 00-54-27
Screenshot from 2021-09-27 00-56-32

@SampsonCrowley
Copy link
Contributor

Nevermind, ignore me. I thought the version lock said <= 3

which why are we putting a maximum version on the new flags anyways? this is just going to keep needing to be rolled out every time, because when a new yarn version is released, the commands will revert to v1, instead of trying to assume compatibility with the most up-to-date api first

@SampsonCrowley
Copy link
Contributor

And ignore me again, the issue above is with sprockets, not with the engine lock. running assets:precompile still attempts to trigger sprockets, even if sprockets is not enabled or installed on an app apparently

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants