Link ios14 #81
Open
Link ios14 #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 28, 2021 09:50
added 3 commits
May 28, 2021 11:41
kevinwl02
suggested changes
Jun 1, 2021
| /// - Parameters: | ||
| /// - label: The visual representation of the label | ||
| /// - destination: The url for the web site | ||
| @available(iOS 14.0, *) |
There was a problem hiding this comment.
There is no constraint for iOS14 in this implementation, you should remove this iOS14 restriction
| /// - Parameters: | ||
| /// - title: the localizedStringKey of the title lebel | ||
| /// - destination: The url for the web site | ||
| @available(iOS 14.0, *) |
There was a problem hiding this comment.
Following your Label PR, you can remove the iOS14 constraint.
| let lastView = view.lastRenderableView?.view as? Self else { return } | ||
|
|
||
| context.viewOperationQueue.addOperation { | ||
| [label].iterateFullViewDiff(oldList: [lastView.label]) { _, operation in |
There was a problem hiding this comment.
Since you only have one label, iterateFullViewDiff is not necessary. Just call label.updateRender directly.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.apple.com/documentation/swiftui/link