Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use DataPublications instead of Studies in ISIS landing pages #1464

Closed
1 task
louise-davies opened this issue Nov 14, 2022 · 0 comments · Fixed by #1514
Closed
1 task

Use DataPublications instead of Studies in ISIS landing pages #1464

louise-davies opened this issue Nov 14, 2022 · 0 comments · Fixed by #1514
Assignees
@louise-davies
Labels
datagateway-dataview Issues corresponding to the dataview component. This component supersedes datagateway-table enhancement New feature or request

Comments

@louise-davies
Copy link
Member

louise-davies commented Nov 14, 2022 •
edited by jounaidr
Loading

Description:
ISIS have/are in the progress of populating DataPublications (see https://github.com/ral-facilities/isis-icat-ingestion/issues/671), which means we can stop using the Study object for DOI landing pages and instead use DataPublications - which are all public by default and contain all the necessary info for the landing pages, which removes the permissioning issues.

We need to refactor both the study view(s) and study landing pages to use DataPublications instead.

Acceptance criteria:

  • Migrate study landing pages & study views to DataPublications
@louise-davies louise-davies added enhancement New feature or request datagateway-dataview Issues corresponding to the dataview component. This component supersedes datagateway-table labels Nov 14, 2022
@louise-davies louise-davies mentioned this issue Feb 8, 2023
Open
1 task
@jounaidr jounaidr mentioned this issue Feb 10, 2023
Merged
louise-davies added a commit that referenced this issue May 19, 2023
@louise-davies
#1464 - fix publication dates, breadcrumbs and unit tests
b297be1 
Also added some TODOs we need to decide on later
louise-davies added a commit that referenced this issue May 23, 2023
@louise-davies
#1464 - fix existing e2e tests & fix DOI filtering and add datapublic…
158dae6 
…ation DOI to ISIS details panel
louise-davies added a commit that referenced this issue May 23, 2023
@louise-davies
#1464 - fix datapublications e2e tests
0da2655
louise-davies added a commit that referenced this issue May 23, 2023
@louise-davies
#1464 - fix facility cycle id check and fix investigation landing pag…
1e87608 
…e e2e test
louise-davies added a commit that referenced this issue May 23, 2023
@louise-davies
#1464 - fix ISIS datafiles table e2e test
b422b1a 
needed different route intercepts for new id check function
louise-davies added a commit that referenced this issue May 23, 2023
@louise-davies
#1464 - fix ISIS datafiles table e2e tests
c4e9632 
needed different route intercepts for new id check function
louise-davies added a commit that referenced this issue Jun 9, 2023
@louise-davies
Merge pull request #1514 from ral-facilities/feature/use-isis-data-pu…
3bf6259 
…blications-#1464

Feature/use isis data publications #1464
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@louise-davies louise-davies

Labels
datagateway-dataview Issues corresponding to the dataview component. This component supersedes datagateway-table enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/use isis data publications #1464 ral-facilities/datagateway
2 participants
@louise-davies @jounaidr