Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Create CITATION.cff #1298

Merged
merged 3 commits into from
Aug 17, 2022
Merged

Create CITATION.cff #1298

merged 3 commits into from
Aug 17, 2022

Conversation

agbeltran
Copy link
Member

Description

Adding citation file; DOI will need to be added later.

Testing instructions

  • check text

Agile board tracking

connect to #1297

Copy link
Contributor

@sam-glendenning sam-glendenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just happened to notice this PR so sorry if this is ahead of a formal review but thought I'd quickly add:

CITATION.cff Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #1298 (62f3610) into develop (e3af540) will decrease coverage by 0.21%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1298      +/-   ##
===========================================
- Coverage    97.49%   97.27%   -0.22%     
===========================================
  Files          134      133       -1     
  Lines         6827     6791      -36     
  Branches      2094     2142      +48     
===========================================
- Hits          6656     6606      -50     
- Misses         155      171      +16     
+ Partials        16       14       -2     
Flag Coverage Δ
common 97.82% <ø> (-0.34%) ⬇️
dataview 97.98% <ø> (+<0.01%) ⬆️
download 94.89% <ø> (-0.08%) ⬇️
search 96.85% <ø> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eway-common/src/views/selectionAlert.component.tsx 92.59% <0.00%> (-5.56%) ⬇️
.../datagateway-common/src/arrowtooltip.component.tsx 71.05% <0.00%> (-5.55%) ⬇️
...table/columnFilters/dateColumnFilter.component.tsx 95.34% <0.00%> (-4.66%) ⬇️
...ckages/datagateway-common/src/sticky.component.tsx 96.42% <0.00%> (-3.58%) ⬇️
...gateway-search/src/search/datePicker.component.tsx 95.45% <0.00%> (-2.63%) ⬇️
packages/datagateway-download/src/App.tsx 72.72% <0.00%> (-2.28%) ⬇️
...teway-search/src/searchPageContainer.component.tsx 92.48% <0.00%> (-1.78%) ⬇️
packages/datagateway-dataview/src/App.tsx 71.42% <0.00%> (-0.99%) ⬇️
packages/datagateway-search/src/App.tsx 73.58% <0.00%> (-0.97%) ⬇️
...rc/detailsPanels/datasetDetailsPanel.component.tsx 90.00% <0.00%> (-0.91%) ⬇️
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3af540...62f3610. Read the comment docs.

Had Akhil's name the wrong way round
Copy link
Contributor

@sam-glendenning sam-glendenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agbeltran this looks good but @louise-davies raised a concern in today's sprint review about whether or not this needed to go in the 1.0.0 release (which could cause difficulties since it's already been released). Apologies if I misremembered that, Louise, please feel free to jump in and clarify if so.

@agbeltran
Copy link
Member Author

@sam-glendenning @louise-davies let's merge this in at the first opportunity

@sam-glendenning
Copy link
Contributor

I'm happy with it, I believe Louise is too so will merge now

@sam-glendenning sam-glendenning merged commit 3528c90 into develop Aug 17, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants