Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Compatibility with Composer 1 broken due to validate command #209

Closed
jrfnl opened this issue Dec 25, 2021 · 1 comment
Closed

Compatibility with Composer 1 broken due to validate command #209

jrfnl opened this issue Dec 25, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@jrfnl
Copy link
Contributor

jrfnl commented Dec 25, 2021

Description

Composer 1.x does not support the --no-check-version and will throw the below error causing the action to error out:

  [Symfony\Component\Console\Exception\RuntimeException]
  The "--no-check-version" option does not exist.

validate [--no-check-all] [--no-check-lock] [--no-check-publish] [-A|--with-dependencies] [--strict] [--] [<file>]

Steps to reproduce

  1. Using Composer 1.x, try to run a composer install via the action and see it fail.
  2. Run `composer validate --strict: it will indicate the composer.json is valid

Example code to reproduce the issue: jrfnl/composer-install-action-bug@98a82bd

Action run showing the bug: https://github.com/jrfnl/composer-install-action-bug/runs/4633075161?check_suite_focus=true

Expected behavior

That the dependencies would be installed without errors when using Composer 1.x.

Environment details

  • version of this package: 2.0.2
  • PHP version: not relevant
  • OS: not relevant
@ramsey
Copy link
Owner

ramsey commented Dec 28, 2021

Fixed in #210

@ramsey ramsey closed this as completed Dec 28, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants