-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore: GH Actions: safeguard compatibility with Composer 1.x #210
chore: GH Actions: safeguard compatibility with Composer 1.x #210
Conversation
... by running both the `expect` tests as well as the integration test against both Composer 1.x as well as 2.x.
267b433
to
998a29b
Compare
I'm removing the development tooling because this causes problems in CI when running tests against Composer v1.
In Composer v2, this option exists to suppress the warning emitted if composer.json contains a "version" property. The option does not exist in v1 and causes problems in CI, as a result.
I took the liberty of making some changes to your branch to get things passing for Composer v1 and v2. Notably, I removed some of the tooling I had in the root I also removed |
Thanks for that!
If you like, you could add a GHA job to at least run
I agree that will probably be rare, though I also have to admit that I ran into it again only the other week... (and removed it from that project: php-parallel-lint/PHP-Code-Style@f1a82cb) |
Heads up for other contributors: the removal of Captain Hook doesn't automatically "clean up" the hooks which were put in place in the |
Sounds good to me. Feel free to set it up, and thanks! |
While looking at the workflow, I saw some more tweaks which could (should) be made, so I've done a more extensive update. PR upcoming. |
Description
Safeguard compatibility with Composer 1.x by running both the
expect
tests as well as the integration test against both Composer 1.x as well as 2.x.Related to #209.
Note: this is just a general test run to allow for discovering further incompatibilities. Depending what is decided about those, this PR will most likely need further adjustments.
Motivation and context
With that in mind, I believe it would be prudent to continue support for Composer 1.x (for the time being).