New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add TotalDuration to benchmark report #3223

Merged

manno merged 1 commit into main from add-total-duration-to-performance-report

Jan 20, 2025

Member

manno commented Jan 17, 2025

Refers to #3217


          Add TotalDuration to benchmark report

ee41246

manno requested a review from a team as a code owner

January 17, 2025 17:05

weyfonk approved these changes

View reviewed changes

benchmarks/deploy_test.go

-              						g.Expect(cluster.Status.Summary.DesiredReady).To(Equal(n*50 + 1))
-              						// we expect the agent to be ready as well
-              						g.Expect(cluster.Status.Summary.Ready).To(Equal(n*50 + 1))
+              						// +1 because we expect the agent to be ready as well

Contributor

weyfonk Jan 20, 2025

Good catch, this is per cluster 👍

manno merged commit 046d1c4 into main

12 checks passed

manno deleted the add-total-duration-to-performance-report branch

January 20, 2025 12:35

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet