Prevent empty Patch updates #3245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kkaempf this PR targets |
weyfonk
approved these changes
Jan 24, 2025
aruiz14
added a commit
to aruiz14/fleet
that referenced
this pull request
Jan 24, 2025
aruiz14
added a commit
to aruiz14/fleet
that referenced
this pull request
Jan 24, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #3163
By adding additional logging to the BundleReconciler, I realized that (in my experiment), every operation was taking ~2.5s, and most of it was on the
updateStatusfunction. It seems that the client implementation will perform the call besides producing an empty JSON patch (which BTW is correct in my opinion).In order to prevent those spurious requests, we need to skip calling
Patch(). This can be done at the cost of generating the diff twice, but it's still worth it.