Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use Docker digest instead of tag to attest provenance #3296

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

thardeck
Copy link
Contributor

@thardeck thardeck commented Feb 3, 2025

Refers to #3075

To fix the warning:

WARNING: Image reference ***/***/fleet:v0.12.0-alpha.7-linux-amd64 uses a tag, not a digest, to identify the image to sign.
    This can lead you to sign a different image than the intended one. Please use a
    digest (example.com/ubuntu@sha256:abc123...) rather than tag
    (example.com/ubuntu:latest) for the input to cosign. The ability to refer to
    images by tag will be removed in a future release.

docker inspect in this form should only work if the image is locally available so there should be no real threat of mixing up images.

Old Github Action output vs New Github Action output

@thardeck thardeck requested a review from a team as a code owner February 3, 2025 11:02
@thardeck thardeck self-assigned this Feb 3, 2025
@thardeck thardeck enabled auto-merge (rebase) February 3, 2025 11:19
@thardeck thardeck merged commit e7d888f into main Feb 3, 2025
12 checks passed
@thardeck thardeck deleted the improve_attestation branch February 3, 2025 12:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants