Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add extra error info when downloading remote charts #3368

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

0xavi0
Copy link
Contributor

@0xavi0 0xavi0 commented Feb 18, 2025

Error example (using the provided git repository)

time="2025-02-18T10:37:59+01:00" level=fatal msg="repo=https://charts.rancher.io chart=rancher-monitoring-crds version=104.1.2+up57.0.3: no chart name found"

Refers to: #3160

@0xavi0 0xavi0 self-assigned this Feb 18, 2025
@0xavi0 0xavi0 force-pushed the 3160-extra-error-downloading-charts branch 3 times, most recently from a383239 to ea8db53 Compare February 18, 2025 13:43
Refers to: rancher#3160

Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
@0xavi0 0xavi0 force-pushed the 3160-extra-error-downloading-charts branch from ea8db53 to 9785c69 Compare February 18, 2025 13:49
@0xavi0 0xavi0 marked this pull request as ready for review February 18, 2025 14:35
@0xavi0 0xavi0 requested a review from a team as a code owner February 18, 2025 14:35
Copy link
Contributor

@weyfonk weyfonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I wonder if Fleet produces other related errors, e.g. when downloading the chart itself, which could be clarified or better exposed as well.

@0xavi0
Copy link
Contributor Author

0xavi0 commented Feb 20, 2025

Yeah, we have also #3234 in which I hope to add context to more errors.
I kept this one simple so we can merge is fast and will go more in deep in the other one ;)

@0xavi0 0xavi0 merged commit 8684928 into rancher:main Feb 20, 2025
12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants