Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[v1.6] add timeout to etcd member add call #3622

Merged
merged 1 commit into from
Jul 2, 2024
Merged

[v1.6] add timeout to etcd member add call #3622

merged 1 commit into from
Jul 2, 2024

Conversation

kinarashah
Copy link
Member

Issue: rancher/rancher#43356

  • Etcd client v3 kept retrying on member add vs v2 client used to return errors so we didn't have timeout earlier
  • DialTimeout alone doesn't suffice, also need to specify client request timeout with context
  • Updated to close all etcd clients as v3 client uses grpc to connect to etcd, could leave us with leaks if not closed

@kinarashah kinarashah requested a review from a team as a code owner June 27, 2024 21:00
jakefhyde
jakefhyde previously approved these changes Jun 27, 2024
View reviewed changes
@snasovich snasovich requested review from a team and jakefhyde July 1, 2024 20:01
@HarrisonWAffel HarrisonWAffel requested a review from a team July 1, 2024 20:54
@kinarashah kinarashah merged commit 0dbc201 into rancher:release/v1.6 Jul 2, 2024
8 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jul 22, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@HarrisonWAffel HarrisonWAffel HarrisonWAffel approved these changes

@jakefhyde jakefhyde jakefhyde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kinarashah @HarrisonWAffel @jakefhyde