Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[release v1.6] added validation error for weave for k8s version >=1.30.0 #3623

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

vardhaman22
Copy link
Contributor

@vardhaman22 vardhaman22 commented Jun 28, 2024

issue: rancher/rancher#45089 and rancher/rancher#45954

  1. weave support needs to be removed for clusters >=v1.30.0 so added a validation for it.
  2. added unit test for the validation.
  3. skipped cluster provisioning and upgrade testing in CI for weave for k8s version >=1.30

Note: Weave related code not removed since rke v1.6.x still supports k8s version >=1.27. Code needs to removed when minimum supported k8s version by rke is v1.30

@vardhaman22 vardhaman22 requested a review from a team as a code owner June 28, 2024 10:15
@vardhaman22 vardhaman22 force-pushed the deprecate-weave branch 2 times, most recently from a9541ad to 090103a Compare June 28, 2024 11:01
manuelbuil
manuelbuil previously approved these changes Jun 28, 2024
@vardhaman22 vardhaman22 changed the title added validation error for weave for k8s version >=1.30.0 [release v1.6] added validation error for weave for k8s version >=1.30.0 Jul 1, 2024
kinarashah
kinarashah previously approved these changes Jul 1, 2024
@vardhaman22 vardhaman22 merged commit 314176f into rancher:release/v1.6 Jul 2, 2024
8 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants