Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

AutoLayout storybook improvements #96

Merged
merged 20 commits into from
Jun 6, 2023

Conversation

nkanigsberg
Copy link
Collaborator

@nkanigsberg nkanigsberg commented Jun 2, 2023

Changes

  • Updated all AutoLayout stories using new designs
    • Made each story interactive
    • Added descriptions to each property and linked to Figma documentation
  • Added a few new stories
  • Cleaned up configs
  • updated all components to beta
  • removed addon-mdx-gfm as it was only installed as part of storybook 7 migration (was giving warnings on startup)

TODO

@codesandbox
Copy link

codesandbox bot commented Jun 2, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Demo App Preview: https://d11mwnosflssyy.cloudfront.net/

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Code Coverage Report

Coverage after merging AutoLayout-storybook-improvements into main

96.72%
Coverage Report
FileBranchesFuncsLinesUncovered Lines
../foundations/generated
   design-tokens.constants.ts100%100%100%
../foundations/generated/icons
   account-circle.tsx100%100%100%
   arrow-left.tsx100%0%75%4
   arrow-right.tsx100%100%100%
   chevron-right.tsx100%0%75%4
   close.tsx100%0%75%4
   event-note.tsx100%0%75%4
   figma.tsx100%100%100%
   github.tsx100%100%100%
   index.ts100%46.67%100%
   instagram.tsx100%100%100%
   linked-in.tsx100%100%100%
   menu.tsx100%100%100%
   schedule.tsx100%0%75%4
   settings.tsx100%0%75%4
   twitter.tsx100%0%75%4
   youtube.tsx100%0%75%4
components/auto-layout
   auto-layout.styles.ts69.44%100%100%..., 28, 62, 63, 64
   auto-layout.tsx100%100%100%
   auto-layout.types.ts100%100%100%
   index.ts100%100%100%
components/button
   button.styles.ts0%100%100%13
   button.tsx100%100%100%
   index.ts100%100%100%
components/footer
   footer.styles.ts100%100%100%
   footer.tsx100%100%100%
   index.ts100%100%100%
components/hero
   hero.styles.ts50%100%100%10
   hero.tsx100%100%100%
   index.ts100%100%100%
components/icon
   icon.styles.ts100%100%100%
   icon.tsx50%100%100%33
   index.ts100%100%100%
components/icon/utils
   index.ts100%100%100%
   with-icon.tsx100%0%40%10, 11, 23
components/image-text-item
   image-text-item.styles.ts100%100%100%
   image-text-item.tsx100%100%100%
   index.ts100%100%100%
components/image-text-list
   image-text-list.tsx100%100%100%
   index.ts100%100%100%
components/inline-link
   index.ts100%100%100%
   inline-link.styles.ts50%100%100%13, 19, 9
   inline-link.tsx66.67%100%100%44, 51
components/link-button
   index.ts100%100%100%
   link-button.styles.ts50%100%100%14, 19, 8, 9
   link-button.tsx83.33%100%100%43
components/link-icon
   index.ts100%100%100%
   link-icon.styles.ts50%100%100%14, 18, 24
   link-icon.tsx66.67%100%100%43, 52
components/nav
   index.ts100%100%100%
   nav.styles.ts50%100%100%33, 50
   nav.tsx66.67%80%95%85, 87, 89
components/nav-item
   index.ts100%100%100%
   nav-item.styles.ts100%100%100%
   nav-item.tsx100%100%100%
components/typography
   index.ts100%100%100%
   typography.styles.ts100%100%100%
   typography.tsx100%100%100%
utils
   design-tokens.utils.ts100%100%100%
   flatten.utils.ts100%100%100%
   index.ts100%100%100%
   styles.utils.ts100%100%100%

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

🎨 Chromatic Results 🎨
Chromatic URL https://www.chromatic.com/build?appId=63cabc3ddcbcfa97ebf8e624&number=158
Storybook Preview https://63cabc3ddcbcfa97ebf8e624-xhjflmfkhj.chromatic.com/
Component Count 16

@nx-cloud
Copy link

nx-cloud bot commented Jun 2, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2fe6c8a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@nkanigsberg nkanigsberg marked this pull request as ready for review June 6, 2023 15:14
@nkanigsberg nkanigsberg merged commit ebf304b into main Jun 6, 2023
@nkanigsberg nkanigsberg deleted the AutoLayout-storybook-improvements branch June 6, 2023 15:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant