Run the spek under cursor when "Run context configuration" occurs #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix isConfigurationFromContext to correctly identify repeated runs of the same test path. Signed-off-by: Travis Grathwell <tgrathwell@pivotal.io>
|
I never knew a shortcut existed :) That's why I didn't bother to test it out. Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that while the plugin adds green arrows to the gutter for running specs, it doesn't do anything when you "Run context configuration" (normally bound to
ctrl + shift + Ron OSX).We've added more logic to
setupConfigurationFromContextandisConfigurationFromContextthat attempts to find the containing Spek block for the cursor position so that the appropriate Spek will be run.We also noticed that run configurations weren't successfully being recycled even when using the gutter arrows, so we added an equality test for Path objects to ensure that the number of run configurations won't continue to grow as you run tests.