Update LogViewerController.php #256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://stackoverflow.com/questions/59674903/trying-to-access-array-offset-on-value-of-type-bool-in-php-7-4 I am getting this error coming from this code: Notice: Trying to access array offset on value of type bool in While deleting the log files from Freescout (which is using your dependency).
mikemand
suggested changes
Oct 14, 2021
There was a problem hiding this comment.
While this is a good change, the null coalescing assignment operator is a PHP 7.4+ only feature. Logviewer is targeted at PHP 5.4+, so anything you do must be compatible or @rap2hpoutre has to drop support for anything less than PHP 7.4 - which is out of the scope of this PR.
All that said, I'm pretty sure @rap2hpoutre is no longer supporting Logviewer. See #251.
|
Fixed via: 1dfd871 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://stackoverflow.com/questions/59674903/trying-to-access-array-offset-on-value-of-type-bool-in-php-7-4
I am getting this error coming from this code:
Notice: Trying to access array offset on value of type bool in
While deleting the log files from Freescout (which is using your dependency).