Major Refactoring of the Code Base #84
Open
+232
−473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anushka255
changed the title
| @@ -917,31 +800,12 @@ def line_search_partial( | |||
| cost_G : float | |||
| The final cost after the update of the transport plan. | |||
| """ | |||
| combined_spatial_cost, a_gradient, b_gradient = ot.gromov.init_matrix( | |||
There was a problem hiding this comment.
This function had its own implementation of computing gradient and cost, and was being passed as a parameter to the generic conditional gradient fn from ot, which then calls this function for line search. Now the cost fn and gradient fn are being passed as parameters.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glmpcaandmodel_selectionfor readability.