Skip to content
This repository was archived by the owner on Oct 19, 2023. It is now read-only.

Support tags which propagate at launch (autoscaling groups) #194

Closed
erran-r7 opened this issue Sep 27, 2016 · 0 comments · Fixed by #195
Closed

Support tags which propagate at launch (autoscaling groups) #194

erran-r7 opened this issue Sep 27, 2016 · 0 comments · Fixed by #195

Comments

@erran-r7
Copy link
Contributor

Description

The Taggable mixin does not support setting tags in the Tags property that set PropagateAtLaunch.

Expected behaviour

The following calls to #tag are valid:

tag 'MyKey1', 'foo'
tag 'MyKey2', 'bar', propagate_at_launch: true
tag 'MyKey3', 'baz', propagate_at_launch: false

Observed behavior

:propagate_at_launch cannot be specified in any way to tags besides using the property method and specifically rendering tags yourself.

Steps to Reproduce

Attempt to propagate a tag at launch.
@erran-r7 erran-r7 changed the title Support tags which propagate at launch Support tags which propagate at launch (autoscaling groups) Sep 27, 2016
erran-r7 pushed a commit that referenced this issue Sep 27, 2016
@erran
Add a failing specs to reproduce #194 and provide regression testing
796bde2 
[ci skip]
@erran-r7 erran-r7 mentioned this issue Sep 27, 2016
Merged
erran-r7 added a commit that referenced this issue Sep 27, 2016
@erran-r7
Merge pull request #195 from rapid7/issue-194/support-autoscaling-tags
1baeb8b 
Fix #194 - support autoscaling tags
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #194 - support autoscaling tags rapid7/convection
1 participant
@erran-r7