This repository has been archived by the owner on Oct 19, 2023. It is now read-only.
Support vpn #133
Merged
Support vpn #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| include Model::Mixin::Taggable | ||
|
|
||
| type 'AWS::EC2::VPNConnection' | ||
| property :conn_type, 'Type' |
There was a problem hiding this comment.
Why use :conn_type? Let's use connection_type since type is taken. It's more clear.
edit: Looks like we even use type in one place, which makes me think while it is used elsewhere naming a property it wouldn't cause a conflict:
lib/convection/model/template/resource_property/aws_cloudfront_georestriction.rb
11: property :type, 'RestrictionType'
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to revisit this at some stage to add some sugar to more easily link up the different resources.
Need to add an example to the docs, too.