This repository has been archived by the owner on Oct 19, 2023. It is now read-only.
Support s3 bucket CorsConfiguration resource property #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,12 +13,18 @@ class S3Bucket < Resource | |||
| type 'AWS::S3::Bucket' | |||
| property :bucket_name, 'BucketName' | |||
| property :access_control, 'AccessControl' | |||
| property :cors_configurationm, 'CorsConfiguration' | |||
| property :cors_configuration, 'CorsConfiguration' | |||
There was a problem hiding this comment.
NOTE: This fix should be pulled in via #135.
|
Looks good, only concern is impacting current stacks, spoke with @erran-r7 with regards to current usage, looks like no other stack references/makes use of CORS. |
@abegley-r7 spoke to @jmanero-r7 and I'm going to address that in #135 with a deprecation warning for the bad property name. |
erran-r7
force-pushed
the
support-s3-bucket-configuration-types
branch
from
7078ca0 to
f4b2d1c
Compare
Done! Merging after tests complete. |
erran-r7
changed the title
erran-r7
changed the title
This was referenced Jul 6, 2016
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are required to support setting the CorsConfiguration through convection.
cc @abegley-r7 @simonirwin-r7 @mmckeaveney-r7