This repository has been archived by the owner on Oct 19, 2023. It is now read-only.
Maintain backwards compatability with route53 #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, users needed to specify the json for alias_target and geo_location for a route53_recordset. In the add-alb branch, merged in PR 214, this was changed in a backwards-incompatible way, requiring anyone who had previously specified json to now specify a block for the resource_property. Now, either way is acceptable. This is potentially a paradigm that can be used elsewhere, as there are many places where a resource_property would be appropriate, but has not existed and users have implemented the functionality directly with a json (or ruby hash) object. This will allow us to deprecate that method in favor of the more clean resource_property approach, without breaking everything in a 1.0 upgrade.
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes alias_target and geo_location in a route53_recordset to allow either json or a resource_property
Motivation and Context
Previously, users needed to specify the json for alias_target and
geo_location for a route53_recordset. In the add-alb branch, merged in
PR 214, this was changed in a backwards-incompatible way, requiring
anyone who had previously specified json to now specify a block for the
resource_property. Now, either way is acceptable.
This is potentially a paradigm that can be used elsewhere, as there are
many places where a resource_property would be appropriate, but has not
existed and users have implemented the functionality directly with a
json (or ruby hash) object. This will allow us to deprecate that method
in favor of the more clean resource_property approach, without breaking
everything in a 1.0 upgrade.
Usage Examples
Testing Steps
Post-merge Steps