Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add fingerprint path to recog verify output #13

Merged
merged 4 commits into from
Oct 11, 2021

Conversation

mkienow-r7
Copy link
Contributor

@mkienow-r7 mkienow-r7 commented Oct 8, 2021

Description

Adds the fingerprint path to the com.rapid7.recog.verify.RecogVerifier output.

Example Output

$mvn --projects recog-verify exec:java -Dexec.mainClass="com.rapid7.recog.verify.RecogVerifier" -Dexec.args="-f s xml/smtp_ehlo.xml"
...
xml/smtp_ehlo.xml: WARN: 'Cisco PIX - changes the command letters to 'X' before passing them to the real SMTP server' has no test cases
xml/smtp_ehlo.xml: WARN: '221 See ya in cyberspace' has no test cases
xml/smtp_ehlo.xml: SUMMARY: Test completed with 0 successful, 2 warnings, and 0 failures
mvn --projects recog-verify exec:java -Dexec.mainClass="com.rapid7.recog.verify.RecogVerifier" -Dexec.args="-f q xml/smtp_ehlo.xml"
...
xml/smtp_ehlo.xml: WARN: 'Cisco PIX - changes the command letters to 'X' before passing them to the real SMTP server' has no test cases
xml/smtp_ehlo.xml: WARN: '221 See ya in cyberspace' has no test cases
mvn --projects recog-verify exec:java -Dexec.mainClass="com.rapid7.recog.verify.RecogVerifier" -Dexec.args="-f d xml/smtp_ehlo.xml"
...

xml/smtp_ehlo.xml:
   WARN: 'Cisco PIX - changes the command letters to 'X' before passing them to the real SMTP server' has no test cases
   WARN: '221 See ya in cyberspace' has no test cases

Verified 2 fingerprints:
SUMMARY: Test completed with 0 successful, 2 warnings, and 0 failures

Motivation and Context

Make the com.rapid7.recog.verify.RecogVerifier output more useful when used with multiple fingerprint XML files.

How Has This Been Tested?

  • All three output formats were tested using com.rapid7.recog.verify.RecogVerifier with the --format option

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

@mkienow-r7 mkienow-r7 merged commit 3eba81c into rapid7:master Oct 11, 2021
@mkienow-r7 mkienow-r7 deleted the feature/add-verify-filename branch October 11, 2021 20:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants