Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enhance recog verify to report an untested parameter as a failure #19

Merged

Conversation

mkienow-r7
Copy link
Contributor

@mkienow-r7 mkienow-r7 commented Jan 31, 2022

Description

Enhances com.rapid7.recog.verify.RecogVerifier to report an untested parameter as a failure instead of a warning. This creates feature parity with changes introduced in rapid7/recog#405.

Motivation and Context

Ensure all fingerprints have examples that fully verify all capture group parameters.

How Has This Been Tested?

  • mvn clean install
  • Manually compared output from rapid7/recog bin/recog_verify tool with output from com.rapid7.recog.verify.RecogVerifier
mvn --projects recog-verify exec:java -Dexec.mainClass="com.rapid7.recog.verify.RecogVerifier" -Dexec.args="$(ls -1 xml/*.xml | xargs)"

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

@mkienow-r7 mkienow-r7 merged commit 9214b67 into rapid7:master Feb 16, 2022
@mkienow-r7 mkienow-r7 deleted the feature/make-missing-parameter-error branch February 16, 2022 23:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants