Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix multimodule checkstyle configuration #21

Merged

Conversation

mkienow-r7
Copy link
Contributor

@mkienow-r7 mkienow-r7 commented May 20, 2022

Description

Fixes the multimodule checkstyle configuration which currently relies on the private and undocumented 12 property maven.multiModuleProjectDirectory. This follows the Apache Maven Checkstyle Plugin example for a Multimodule Configuration.

Motivation and Context

The solution using maven.multiModuleProjectDirectory is not stable given it relies on a private and undocumented property limited to Maven versions 3.3.1 and greater. In addition, the current configuration fails to build successfully on the build server.

How Has This Been Tested?

  • mvn clean install
  • Modified build-tools/src/main/resources/recog-java/google_checks.xml and java source to introduce a checkstyle error. Ran mvn clean install and confirmed checkstyle error.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

Footnotes

  1. MNG-6589 - Document property maven.multiModuleProjectDirectory

  2. MNG-7038 - Introduce public property to point to a root directory of (multi-module) project

@mkienow-r7 mkienow-r7 merged commit 007763e into rapid7:master May 20, 2022
@mkienow-r7 mkienow-r7 deleted the feature/fix-multi-module-checkstyle branch May 20, 2022 13:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants