Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add additional attributes to client #112

Closed
dmohanty-r7 opened this issue Oct 23, 2017 · 0 comments · Fixed by #117
Closed

Add additional attributes to client #112

dmohanty-r7 opened this issue Oct 23, 2017 · 0 comments · Fixed by #117

Comments

@dmohanty-r7
Copy link
Contributor

dmohanty-r7 commented Oct 23, 2017

As brought to attention by @chrisdlf : Currently we are only capturing the peer_native_os attribute from the SMB_COM_SESSION_SETUP_ANDX response in the client.

https://github.com/rapid7/ruby_smb/blob/master/lib/ruby_smb/client/authentication.rb#L37 https://github.com/rapid7/ruby_smb/blob/master/lib/ruby_smb/client/authentication.rb#L79

In REX we additionally get the following attributes from SMB_COM_SESSION_SETUP_ANDX

  • peer_native_lm

also in REX we get these from the NTLM type 2 challenge blob:

  • default_name
  • dns_host_name
  • default_domain
  • dns_domain_name (this one has been removed recently from Rex but it was there before)

https://github.com/rapid7/metasploit-framework/blob/master/lib/rex/proto/smb/client.rb#L901
https://github.com/rapid7/metasploit-framework/blob/master/lib/rex/proto/smb/client.rb#L561

We should be adding these additional useful attributes of information in the client.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant