Add attributes to client #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, customize the NTLM client flags to make sure the peer/server will return as much information as possible.
Also, add helper methods to the SMB1 NegotiateResponse and NegotiateResponseExtended classes.
…peer/server information
n00tmeg
commented
Nov 30, 2017
| @@ -123,11 +171,17 @@ def initialize(dispatcher, smb1: true, smb2: true, username:, password:, domain: | |||
| @username = username.encode('utf-8') || ''.encode('utf-8') | |||
| @max_buffer_size = MAX_BUFFER_SIZE | |||
|
|
|||
| negotiate_version_flag = 0x02000000 | |||
There was a problem hiding this comment.
The NEGOTIATE_VERSION flag is missing in rubyntlm library. I had to manually add it. I also submitted a PR to add it: WinRb/rubyntlm#38
…ttributes_to_client
busterb
approved these changes
Nov 30, 2017
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the following attributes to the Client:
Some negotiation and authentication methods/classes needed to be update in order to sets these attributes.
This fixes #112 .
Verification Steps
bundle installruby examples/authenticate.rb <ip-address> <username> <password>ruby examples/anonymous_auth.rb <ip-address>rake specrake spec