Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor class naming for zeitwerk standard #243

Merged
merged 1 commit into from
Jan 31, 2023
Merged

refactor class naming for zeitwerk standard #243

merged 1 commit into from
Jan 31, 2023

Conversation

jmartin-tech
Copy link
Contributor

Implements comments from #238 about ensuring class name in file matches zeitwerk format for path, this does not yet account for inflectors for RubySMB and NTLM however it gets closer to supporting the zeitwerk patterns.

@smcintyre-r7
Copy link
Contributor

These changes make sense. Are there any steps for testing anything related to this though?

@jmartin-tech
Copy link
Contributor Author

Same tests as #238, just need to validate that this still works as expected.

@smcintyre-r7
Copy link
Contributor

Original fix is still working as expected. I'll get this landed. Thanks @jmartin-r7 !

ruby examples/tree_connect.rb --username юзер --password 'Password1!' 192.168.159.10 IPC$
SMB3 : (0x00000000) STATUS_SUCCESS: The operation completed successfully.
Connected to \\192.168.159.10\IPC$ successfully!

@smcintyre-r7 smcintyre-r7 self-assigned this Jan 31, 2023
@smcintyre-r7 smcintyre-r7 merged commit fc03a95 into rapid7:master Jan 31, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@smcintyre-r7 smcintyre-r7

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmartin-tech @smcintyre-r7