Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Clear session timeouts when wait rejects timeout resume #608

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

rowanseymour
Copy link
Contributor

No description provided.

@rowanseymour rowanseymour changed the title Fix timed events for stopped contacts Add test for timeout events Mar 24, 2022
@rowanseymour rowanseymour marked this pull request as ready for review March 24, 2022 18:22
@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #608 (460cb9f) into main (736b5c7) will increase coverage by 0.14%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##             main     #608      +/-   ##
==========================================
+ Coverage   62.20%   62.35%   +0.14%     
==========================================
  Files         126      126              
  Lines        8880     8888       +8     
==========================================
+ Hits         5524     5542      +18     
+ Misses       2495     2483      -12     
- Partials      861      863       +2     
Impacted Files Coverage Δ
core/tasks/handler/worker.go 51.42% <80.00%> (+2.37%) ⬆️
core/handlers/msg_created.go 73.91% <100.00%> (ø)
core/models/sessions.go 53.69% <100.00%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 736b5c7...460cb9f. Read the comment docs.

@rowanseymour rowanseymour changed the title Add test for timeout events Clear session timeouts when wait rejects timeout resume Mar 29, 2022
@rowanseymour rowanseymour merged commit 83c16d9 into main Mar 29, 2022
@rowanseymour rowanseymour deleted the timeout_fix branch March 29, 2022 19:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant