Failed sessions should be inserted with ended_on set
#644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
force-pushed
the
failed_session_fix
branch
from
6798fbe to
482d911
Compare
Codecov Report
@@ Coverage Diff @@
## main #644 +/- ##
=======================================
Coverage 61.99% 61.99%
=======================================
Files 132 132
Lines 12945 12944 -1
=======================================
Hits 8025 8025
+ Misses 4054 4053 -1
Partials 866 866
Help us with your feedback. Take ten seconds to tell us how you rate us. |
rowanseymour
commented
Jul 25, 2022
|
|
||
| // if writing our sessions to S3, do so | ||
| if rt.Config.SessionStorage == "s3" { | ||
| err := WriteSessionOutputsToStorage(ctx, rt, sessions) | ||
| if err != nil { | ||
| // for now, continue on for errors, we are still reading from the DB | ||
| logrus.WithError(err).Error("error writing sessions to s3") | ||
| return nil, errors.Wrapf(err, "error writing sessions to storage") |
There was a problem hiding this comment.
this is a holdover from when we always read output from DB and we were just testing S3 writes - if S3 writing fails now, that's an error
norkans7
reviewed
Jul 25, 2022
core/models/sessions_test.go
Outdated
| modelContact, _ := testdata.Cathy.Load(db, oa) | ||
|
|
||
| _, flowSession, sprint1 := test.NewSessionBuilder().WithAssets(oa.SessionAssets()).WithFlow(ping.UUID). | ||
| WithContact(testdata.Bob.UUID, flows.ContactID(testdata.Cathy.ID), "Cathy", "eng", "").MustBuild() |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We set this correctly if things fail on later resumes, but in the insert case after the first sprint, we only set ended_on for status=C sessions.