Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use the 21.08 branch of rapids-cmake as rmm requires it #1683

Merged

Conversation

robertmaynard
Copy link
Contributor

Now that rmm uses rapids-cmake we need to update to the 21.08 branch to get the new rapids_cmake_write_version_file function

@robertmaynard robertmaynard requested a review from a team as a code owner June 22, 2021 16:02
@ChuckHastings ChuckHastings added Fix non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jun 22, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2021

Codecov Report

Merging #1683 (2079c87) into branch-21.08 (d01da40) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 2079c87 differs from pull request most recent head f130938. Consider uploading reports for the commit f130938 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.08    #1683      +/-   ##
================================================
+ Coverage         59.77%   59.79%   +0.02%     
================================================
  Files                80       80              
  Lines              3540     3542       +2     
================================================
+ Hits               2116     2118       +2     
  Misses             1424     1424              
Impacted Files Coverage Δ
python/cugraph/_version.py 44.80% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d01da40...f130938. Read the comment docs.

@BradReesWork BradReesWork added this to the 21.08 milestone Jun 23, 2021
@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0cbbdd8 into rapidsai:branch-21.08 Jun 23, 2021
@robertmaynard robertmaynard deleted the use_rapids_cmake_21.08 branch August 26, 2021 13:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants